Code refactoring #360
Merged
Code refactoring #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: Namespace namings Changed: Copyright from 2022 to 2023 Fixed: Incorrect naming conventions (Refactored: Application)
Fixed: Namespace namings Fixed: Incorrect naming conventions (Refactored: Server.UI)
(Refactored: Domain)
Fixed: Namespace namings Fixed: Incorrect naming conventions (Refactored: Infrastructure)
Fixed: Incorrect naming conventions (Refactored: Unit Tests)
neozhu
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big Code Refactoring
I spent quite some time refactoring this code. If you have any questions about why I changed a certain thing let me know.
Besides the things I changed, I saw quite a few other things that I wanted to change, but I didn't feel like it would be a good idea to include them within this pull request, since they were rather specific, and shouldn't be included in general refactoring.
I'm planning on making additional pull requests, but I first wanted to apply the coding conventions throughout the whole project for consistency.