Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacing signalR #381

Merged
merged 4 commits into from
May 8, 2023
Merged

refacing signalR #381

merged 4 commits into from
May 8, 2023

Conversation

neozhu
Copy link
Owner

@neozhu neozhu commented May 7, 2023

  • register DI Scoped instead of Transient for HubClient.

I'm planning to add some new features to the Notification Service. Specifically, I'm thinking about developing a simple online chat or messaging feature using SignalR. Recently, I've been working on a personal project related to approval workflows for various types of requests. Currently, we're using email notifications to keep everyone informed of the latest status updates. However, I think it would be a great idea to integrate the notification content and any outstanding messages into the system itself.
Of course, I know that the real challenge here isn't developing the SignalR service, but rather designing the UI for the front-end. Do you have any good ideas for how we could approach this?

register DI Scoped instead of  Transient for HubClient
@neozhu neozhu requested a review from Bram1903 May 7, 2023 12:36
@Bram1903
Copy link
Collaborator

Bram1903 commented May 7, 2023

I really love your idea, since it would greatly improve the user experience in general, since having to keep track of your email for such announcements may be rather annoying, and personally I would prefer a system where I would get a notification within the system itself, which is exactly what you want to do.

In response to your question if I had a good idea for designing the UI. Don't you already have a little notification icon in the navbar, which could be used for receiving notifications? You could make it so that when someone receives a notification the notification shows only a title, and when you click on it, a MudDialog pops up, with the actual notification with some additional details.

Should we take this conversation to #375?

@neozhu neozhu merged commit 53ea1f7 into main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants