Privacy feature for logging client information #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Privacy feature for logging client information
This pull request adds support for dynamically setting whether the server should include client IP addresses and/or client agents.
If someone decides they want to use this code base, but don't want to log certain privacy-sensitive information, they can decide to either turn both options off or switch a certain option off.
This may help people who are publicly using his application in the sense of many administrators and don't want their server to log client-sensitive information.
LogClientIpAddresses
: When disabled won't include the client IP address within the logging system.LogClientAgents
: When disabled won't include the client's agent within the logging system.Besides the above, this also fixes #391
Screenshots:
Privacy Settings:
Logging settings enabled vs disabled:
Side Note
Refer to commenting in JSON files, because if you don't have to proper tools installed it will throw errors, which would be confusing for someone who freshly clones this project. See the error below:
JSON standard does not allow comments. Use JSMin or similar tool to remove comments before parsing.