Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Duende.IdentityServer packages #403

Merged
merged 1 commit into from
Jun 8, 2023
Merged

remove Duende.IdentityServer packages #403

merged 1 commit into from
Jun 8, 2023

Conversation

neozhu
Copy link
Owner

@neozhu neozhu commented Jun 8, 2023 •
edited

remove:

<PackageReference Include="Duende.IdentityServer" Version="6.3.1" />
<PackageReference Include="Duende.IdentityServer.AspNetIdentity" Version="6.3.1" />
<PackageReference Include="Duende.IdentityServer.EntityFramework" Version="6.3.1" />
<PackageReference Include="Duende.IdentityServer.EntityFramework.Storage" Version="6.3.1" />
<PackageReference Include="Duende.IdentityServer.Storage" Version="6.3.1" />

add:

<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="7.0.5" />
<PackageReference Include="Microsoft.Extensions.Identity.Core" Version="7.0.5" />

fixed:
state.User.Identity.IsAuthenticated instead of state.User.IsAuthenticated()

@neozhu neozhu linked an issue Jun 8, 2023 that may be closed by this pull request
Duende Packages #401
Closed
@neozhu neozhu marked this pull request as ready for review June 8, 2023 02:14
Bram1903
Bram1903 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@Bram1903 Bram1903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work man! I didn't even think of that option within the identity user itself, while I have used it many times!

I have no idea what's going on with CodeQL. Somehow it says it's failing to build, but I'll take a closer look at that later!

@neozhu neozhu merged commit 8149e29 into main Jun 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bram1903 Bram1903 Bram1903 approved these changes

Assignees

@Bram1903 Bram1903

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duende Packages
2 participants
@neozhu @Bram1903