Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed removing the "tenantId" filter in the Superior dropdown list #407

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

neozhu
Copy link
Owner

@neozhu neozhu commented Jun 9, 2023

@neozhu neozhu linked an issue Jun 9, 2023 that may be closed by this pull request
@neozhu neozhu requested a review from Bram1903 June 9, 2023 11:11
@Bram1903
Copy link
Collaborator

Bram1903 commented Jun 9, 2023

@neozhu

I'm a bit confused. When I test this I now always get the option to select every user no matter which tenant they are in. Is this meant to be?

I also tried creating a new user within a tenant which doesn't have any users yet, to then create another user, but I still get all the users from a separate tenant.

@neozhu
Copy link
Owner Author

neozhu commented Jun 9, 2023

@neozhu

I'm a bit confused. When I test this I now always get the option to select every user no matter which tenant they are in. Is this meant to be?

I also tried creating a new user within a tenant which doesn't have any users yet, to then create another user, but I still get all the users from a separate tenant.

The purpose of selecting a superior is solely for the correct display of the org chart. There is no other intention, and the superior field can indeed be left blank if desired.

@Bram1903
Copy link
Collaborator

Bram1903 commented Jun 9, 2023

@neozhu
I'm a bit confused. When I test this I now always get the option to select every user no matter which tenant they are in. Is this meant to be?
I also tried creating a new user within a tenant which doesn't have any users yet, to then create another user, but I still get all the users from a separate tenant.

The purpose of selecting a superior is solely for the correct display of the org chart. There is no other intention, and the superior field can indeed be left blank if desired.

When I tried to create a user without a superior it still gives me an error stating that I need to specify a superior.

@neozhu
Copy link
Owner Author

neozhu commented Jun 9, 2023

@neozhu
I'm a bit confused. When I test this I now always get the option to select every user no matter which tenant they are in. Is this meant to be?
I also tried creating a new user within a tenant which doesn't have any users yet, to then create another user, but I still get all the users from a separate tenant.

The purpose of selecting a superior is solely for the correct display of the org chart. There is no other intention, and the superior field can indeed be left blank if desired.

When I tried to create a user without a superior it still gives me an error stating that I need to specify a superior.

image

comment out

@neozhu neozhu marked this pull request as ready for review June 16, 2023 07:47
@neozhu neozhu merged commit bcfec64 into main Jun 16, 2023
2 of 3 checks passed
@Bram1903 Bram1903 deleted the 406-superior-dropdown-empty branch June 26, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superior dropdown empty
2 participants