Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the Features directory in the Application layer #416

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Refactored the Features directory in the Application layer #416

merged 1 commit into from
Jun 26, 2023

Conversation

Bram1903
Copy link
Collaborator

@Bram1903 Bram1903 commented Jun 26, 2023 •
edited

I was taking another look at the features directory after the Mapper simplifications you added yesterday, and thought it would be a good idea to refactor some of its files ;-)

  • Removed: Unused ApplicationDbContext service from the injection pipeline in DocumentCreatedEventHandler.
  • Fixed: Logger category namings in a few EventHandler files.
  • Fixed: Namespace namings in a few files.
  • Fixed: Line Indenting
  • Reduced: Nesting Blocks
  • Changed: Variable namings according to the namings conventions.

@Bram1903 Bram1903 added the Enhancement New feature or request label Jun 26, 2023
@Bram1903 Bram1903 requested a review from neozhu June 26, 2023 08:34
@Bram1903 Bram1903 self-assigned this Jun 26, 2023
neozhu
neozhu approved these changes Jun 26, 2023
View reviewed changes
Copy link
Owner

@neozhu neozhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@neozhu neozhu merged commit 860e542 into main Jun 26, 2023
@Bram1903 Bram1903 deleted the Features-Refactoring branch June 26, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neozhu neozhu neozhu approved these changes

Assignees

@Bram1903 Bram1903

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bram1903 @neozhu