Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Loading Screen Component #482

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

bakes82
Copy link
Contributor

@bakes82 bakes82 commented Aug 24, 2023

Adds the loading screen to the App.Razor for initial page rendering/full page refreshes, customize with the delayMS, colors are inherited from the LayoutService.

bakes82 and others added 2 commits August 24, 2023 00:19
A change was made to the App.razor, DashboardSettings.cs, and appsettings.json files to add a configurable loading screen duration setting in the application. Now, users can adjust the duration of the loading screen according to their preferences. This change makes the application more customizable and user-friendly.
@Bram1903
Copy link
Collaborator

Bram1903 commented Aug 24, 2023

Hello @bakes82,

I want to express my gratitude for your assistance – it has been incredibly valuable. The loading screen component you've crafted is truly impressive, and I'm thoroughly impressed with its design.

I'd like to bring up a couple of points for consideration. Currently, the loading screen lacks user customization options, specifically the ability for administrators to choose whether they want to enable or disable it, as well as the option to adjust the duration it remains visible. This level of flexibility would be quite beneficial, given the variability in server performance. Of course, you already added the duration parameter as an option, but this cannot be set without touching the code itself, or I have overlooked something 😇.

On a related note, I've already incorporated the customization features for enabling/disabling the loading screen and modifying its duration within this pull request.

On a different topic, I've encountered a bit of a puzzle. When users who aren't logged in attempt to do so, they encounter the waiting screen – which makes sense. However, after a successful login, the loading screen reappears. My assumption is that our internal authentication controller might be responsible, potentially due to browser redirection and forceful reloading to ensure data accuracy. If it's possible within your availability, could you please look into this issue? The goal is to streamline the experience so that non-logged-in users don't encounter the loading screen twice.

Additionally, I've been wondering if the content behind the loading screen is actually rendering components. Currently, it seems like the loading screen is displayed without any real content rendering until the loading screen is finished. This becomes evident when I toggle the loading screen on or off – the time it takes for me to be logged in remains the same, as indicated by the loading icon in the top left corner where your username is displayed. While a purely cosmetic loading screen might be unnecessary, I might be overlooking something, or my device is too quick to be able to see a difference in rendering.

Thank you for your dedication and expertise in addressing these matters.

Kind regards,
Bram

@Bram1903 Bram1903 self-requested a review August 24, 2023 09:30
@Bram1903 Bram1903 added the Enhancement New feature or request label Aug 24, 2023
@Bram1903 Bram1903 changed the title Add Loading Screen Component. [Feature] Loading Screen Component Aug 24, 2023
Copy link
Owner

@neozhu neozhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you

@neozhu neozhu merged commit 051fced into neozhu:main Aug 24, 2023
3 checks passed
@Bram1903
Copy link
Collaborator

nice! thank you

Why did you merge it, while I still asked for a few changes? Currently it has a double loading screen upon logging in, and I had a question based on the actual benefit of rendering?

@neozhu
Copy link
Owner

neozhu commented Aug 24, 2023

😁sorry, you can continue this topic. or create a new branch

@Bram1903 Bram1903 linked an issue Aug 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature/Sample] Loading Screen
3 participants