Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading screen #496

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Loading screen #496

merged 7 commits into from
Aug 28, 2023

Conversation

bakes82
Copy link
Contributor

@bakes82 bakes82 commented Aug 28, 2023

This should resolve all the issues with loading screen, also toggle for both full page load and transition page load both with custom timers.

Opening new issue for the nav page not remembering when full page refresh, thats present regardless of loading screen.

@Bram1903 Bram1903 added the Enhancement New feature or request label Aug 28, 2023
Copy link
Collaborator

@Bram1903 Bram1903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing phase went smoothly, and the adjustments suggested by @neozhu have been properly implemented and applied.

A minor bug still remains, where the LoadingScreen component is displayed twice for non-logged-in users. We could address this issue in a future update if feasible.

@neozhu, if this meets your expectations, please go ahead with the merging process.

@neozhu neozhu merged commit 8f48d14 into neozhu:main Aug 28, 2023
3 checks passed
@neozhu
Copy link
Owner

neozhu commented Aug 28, 2023

unknown_2023.08.28-19.11.mp4

Please check the video. When pressing F5 to refresh the Home Page, the page is rendered immediately, and then the transition animation is loaded. The first version you submitted didn't have this issue

@neozhu
Copy link
Owner

neozhu commented Aug 28, 2023

This screen was recorded using the first version. You can simply press F5 to refresh the page.

unknown_2023.08.28-19.20.mp4

@neozhu neozhu mentioned this pull request Aug 28, 2023
@bakes82
Copy link
Contributor Author

bakes82 commented Aug 28, 2023

Your videos show two diffrent things, one is logging out and the logging in again, and the other is pressing reload on a page. I also cant see where the non auth user sees it twice. If that means the LogOut button shows it and then the login, then yes, thats because the code has it set that way to force load in the LogOut (NavigationManager.NavigateTo("/", true); It also looks like you have a bad merge or something just based on how the pages are transitioning.

TransitionSetting = False
lsonly

TransitionSetting = True
lsboth

@Bram1903
Copy link
Collaborator

Your videos show two diffrent things, one is logging out and the logging in again, and the other is pressing reload on a page. I also cant see where the non auth user sees it twice. If that means the LogOut button shows it and then the login, then yes, thats because the code has it set that way to force load in the LogOut (NavigationManager.NavigateTo("/", true); It also looks like you have a bad merge or something just based on how the pages are transitioning.

TransitionSetting = False

lsonly

TransitionSetting = True

lsboth

I disabled the TransitionSetting by default in the settings. This is because he didn't want to have the LoadingScreen in between navigation changes and neither do I. However having the setting allows users to either enable or disable it themselves, but by default it's disabled. Is that what you mean with bad merge?

@bakes82
Copy link
Contributor Author

bakes82 commented Aug 28, 2023

In the first video posted at around 11/12 seconds you see the whole page go white, and then the loading screen

@neozhu
Copy link
Owner

neozhu commented Aug 28, 2023

In the first video posted at around 11/12 seconds you see the whole page go white, and then the loading screen

The login/logout animation effect is acceptable. What you need to test is that when you press F5 to refresh the page, the page loads for a brief moment before the animation loads.

@bakes82
Copy link
Contributor Author

bakes82 commented Aug 29, 2023

The issue you're talking about seems more dependant on how fast it taks for your server to start sending back data to the client. When you do a full page refresh you need to server to start sending back the css and everything so if the on "wire" wait time is higher due to latency etc you just see a blank white page until the CSS/site data gets sent, you can easily see that by opening the developer tools. Also someone pushed in changes that change the audit table from int to guid and never updated other migrations

I pushed code here, you can probably see it as the site "loads" initially as the service will probably be stopped, but then after its been up for a min it should mostly go away, but its also in a East USA DC so maybe latency could be different.
https://lstestsite.azurewebsites.net/

@neozhu
Copy link
Owner

neozhu commented Aug 29, 2023

I will test it again.

@neozhu
Copy link
Owner

neozhu commented Aug 29, 2023

Thank you for your effort., I just reverted the "reverted Loading screen" back to its previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants