Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ reaming the "NavMenu" -> "HeaderMenu" and "SideMenu" -> "Navigation… #502

Merged
merged 1 commit into from
Aug 31, 2023
Merged

✨ reaming the "NavMenu" -> "HeaderMenu" and "SideMenu" -> "Navigation… #502

merged 1 commit into from
Aug 31, 2023

Conversation

neozhu
Copy link
Owner

@neozhu neozhu commented Aug 30, 2023

…Menu"

@neozhu neozhu requested a review from Bram1903 August 30, 2023 11:10
@neozhu neozhu linked an issue Aug 30, 2023 that may be closed by this pull request
[Bug] Navigation doesnt update on full load #497
Closed
@neozhu neozhu mentioned this pull request Aug 30, 2023
Closed
@Bram1903
Copy link
Collaborator

@bakes82, anything you want to add to this PR?

@Bram1903 Bram1903 added the Enhancement New feature or request label Aug 30, 2023
@bakes82
Copy link
Contributor

bakes82 commented Aug 31, 2023

Its fine as a rename only task, the real issue is setting the "expand" option for full page reloads which can be another.

@neozhu neozhu merged commit 80eb284 into main Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bram1903 Bram1903 Bram1903 approved these changes

Assignees

@neozhu neozhu

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Navigation doesnt update on full load
3 participants
@neozhu @Bram1903 @bakes82