Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding identity password settings to appsettings.json #508

Merged
merged 5 commits into from
Sep 2, 2023

Conversation

Aaron2404
Copy link
Contributor

@Aaron2404 Aaron2404 commented Sep 1, 2023

  • Added identity password settings to appsettings.json
  • Made the password validations and the messages in RegisterFormModelFluentValidator.cs synced with the settings instead of being hardcoded (before this was fine as it was not configurable anyway)
  • Changed the names of the validation translations to short variable-like names instead of the entire English value which should make it look more clean.

@Aaron2404 Aaron2404 changed the title Adding identity passwotrd settings to appsettings.json Adding identity password settings to appsettings.json Sep 1, 2023
Copy link
Collaborator

@Bram1903 Bram1903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@neozhu, this is a friend of mine, and because I'm not certain if this is what you want, you can merge it, or add changes as you like.

@neozhu
Copy link
Owner

neozhu commented Sep 2, 2023

@BoostioAaron I appreciate it a lot.

@neozhu neozhu merged commit 13bc7f6 into neozhu:main Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants