Strict hidden input value type handling

nepada · Feb 9, 2024 · 005c5f3 · 005c5f3
1 parent 677099e
commit 005c5f3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/FileUploadControl/FileUploadControl.php b/src/FileUploadControl/FileUploadControl.php
@@ -426,8 +426,9 @@ protected function getThumbnailProvider(): ThumbnailProvider
 
     protected function getUploadNamespace(): UploadNamespace
     {
-        $nameSpaceValue = (string) $this->getNamespaceControl()->getValue();
-        if (UploadNamespace::isValid($nameSpaceValue)) {
+        /** @var string|null $nameSpaceValue */
+        $nameSpaceValue = $this->getNamespaceControl()->getValue();
+        if ($nameSpaceValue !== null && UploadNamespace::isValid($nameSpaceValue)) {
             return UploadNamespace::fromString($nameSpaceValue);
         }
 

diff --git a/tests/PHPStan/conditional.config.php b/tests/PHPStan/conditional.config.php
@@ -24,11 +24,6 @@
 }
 
 if (InstalledVersions::satisfies(new VersionParser(), 'nette/forms', '<3.2')) {
-    $config['parameters']['ignoreErrors'][] = [
-        'message' => '#^Cannot cast mixed to string\\.$#',
-        'path' => '../../src/FileUploadControl/FileUploadControl.php',
-        'count' => 1,
-    ];
     $config['parameters']['ignoreErrors'][] = [
         'message' => '#^Return type \\(string\\|Stringable\\|null\\) of method Nepada\\\\FileUploadControl\\\\Validation\\\\FakeUploadControl\\:\\:getCaption\\(\\) should be covariant with return type \\(object\\|string\\) of method Nette\\\\Forms\\\\Controls\\\\BaseControl\\:\\:getCaption\\(\\)$#',
         'path' => '../../src/FileUploadControl/Validation/FakeUploadControl.php',