Enable new shipmonk phpstan rules

nepada · Oct 23, 2022 · 42c64b9 · 42c64b9
1 parent 4553d2a
commit 42c64b9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -30,7 +30,7 @@
         "phpstan/phpstan-strict-rules": "1.4.4",
         "nepada/phpstan-nette-tester": "1.0.0",
         "spaze/phpstan-disallowed-calls": "2.5.0",
-        "shipmonk/phpstan-rules": "1.1.1",
+        "shipmonk/phpstan-rules": "1.2.0",
         "php-parallel-lint/php-parallel-lint": "1.3.2",
         "nepada/coding-standard": "7.5.2"
     },

diff --git a/phpstan.tests.neon.dist b/phpstan.tests.neon.dist
@@ -35,3 +35,7 @@ parameters:
             message: "#^Parameter \\#1 \\$callback of function array_map expects \\(callable\\(array\\<Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\StampInterface\\>\\|Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\StampInterface\\)\\: mixed\\)\\|null, Closure\\(Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\HandledStamp\\)\\: string given\\.$#"
             count: 1
             path: tests/MessageBus/Middleware/LoggingMiddlewareTest.phpt
+        - # false positive
+            message: "#^Invalid var phpdoc of \\$handledStamps\\. Cannot assign array\\<array\\<Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\StampInterface\\>\\|Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\StampInterface\\> to array\\<Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\HandledStamp\\>$#"
+            count: 1
+            path: tests/MessageBus/Middleware/PreventNestedHandlingMiddlewareTest.phpt
diff --git a/tests/PHPStan/shipmonk.neon b/tests/PHPStan/shipmonk.neon
@@ -1,14 +1,23 @@
 rules:
+    - ShipMonk\PHPStan\Rule\BackedEnumGenericsRule
+    - ShipMonk\PHPStan\Rule\ForbidAssignmentNotMatchingVarDocRule
+    - ShipMonk\PHPStan\Rule\ForbidEnumInFunctionArgumentsRule
     - ShipMonk\PHPStan\Rule\ForbidFetchOnMixedRule
     - ShipMonk\PHPStan\Rule\ForbidMatchDefaultArmForEnumsRule
     - ShipMonk\PHPStan\Rule\ForbidMethodCallOnMixedRule
     - ShipMonk\PHPStan\Rule\ForbidReturnInConstructorRule
     - ShipMonk\PHPStan\Rule\ForbidUnsetClassFieldRule
     - ShipMonk\PHPStan\Rule\ForbidUnusedExceptionRule
+    - ShipMonk\PHPStan\Rule\ForbidUnusedMatchResultRule
+    - ShipMonk\PHPStan\Rule\ForbidVariableTypeOverwritingRule
     - ShipMonk\PHPStan\Rule\RequirePreviousExceptionPassRule
 
 services:
     -
         type: ShipMonk\PHPStan\Visitor\UnusedExceptionVisitor
         tags:
             - phpstan.parser.richParserNodeVisitor
+    -
+        class: ShipMonk\PHPStan\Visitor\UnusedMatchVisitor
+        tags:
+            - phpstan.parser.richParserNodeVisitor