Fix support for secure_url (#110)

nephila · Jul 7, 2020 · f1b0e66 · f1b0e66
1 parent dee630a
commit f1b0e66
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/meta/templatetags/meta.py b/meta/templatetags/meta.py
@@ -120,9 +120,10 @@ def og_prop(name, value):
     :param name: property name (without 'og:' namespace)
     :param value: property value
     """
+    content = [custom_meta('property', 'og:%s' % name, value)]
     if name in settings.OG_SECURE_URL_ITEMS and value.startswith('https'):
-        name = '%s:secure_url' % name
-    return custom_meta('property', 'og:%s' % name, value)
+        content.append(custom_meta('property', 'og:%s:secure_url' % name, value))
+    return '\n'.join(content)
 
 
 @register.simple_tag

diff --git a/tests/test_mixin.py b/tests/test_mixin.py
@@ -196,6 +196,7 @@ def test_templatetag_secure_image(self):
         self.assertContains(response, '<meta property="og:image" content="http://example.com/path/to/image">')
         settings.SITE_PROTOCOL = 'https'
         response = self.client.get('/mixin/title/')
+        self.assertContains(response, '<meta property="og:image" content="https://example.com/path/to/image">')
         self.assertContains(response, '<meta property="og:image:secure_url" content="https://example.com/path/to/image">')
         settings.SITE_PROTOCOL = 'http'
 

diff --git a/tests/test_templatetags.py b/tests/test_templatetags.py
@@ -21,6 +21,7 @@ def test_og_prop_secure_url(self):
         for content in ('image', 'video', 'audio'):
             self.assertEqual(
                 og_prop(content, 'https://some/{}'.format(content)),
+                '<meta property="og:{0}" content="https://some/{0}">\n'
                 '<meta property="og:{0}:secure_url" content="https://some/{0}">'.format(content),
             )
             self.assertEqual(