Enable creating custom meta properties #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murataydos I no longer maintain this code base. Also I'm not using Django anymore, so I'm not sure I should be commenting on this generally. :) |
|
@murataydos Thanks for your contribuion. I'll have a look at this shortly |
|
LGTM |
yakky
added a commit
that referenced
this pull request
Dec 11, 2014
Enable creating custom meta properties
|
@yakky Can you create a tag for the last changes to update version on PyPI? |
|
I'll release it shortly, before completing some tests in internal projects |
|
Great thanks :) |
|
Released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced four new attributes.
twitter_siteto add site property to twitter properties like<meta name="twitter:site" content="@foo">localeto add locale property to facebook properties like<meta property="og:locale" content="en_US">meta_extrasto add optional properties like<meta name="foo" content="bar">meta_custom_extrasto add optional custom properties like<meta some_key="foo" content="bar">@foxbunny Can you review this? Thank you.