Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty menu cache when deleting blogconfig instances #497

Merged
merged 1 commit into from
Aug 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions djangocms_blog/cms_menus.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,3 +191,4 @@ def clear_menu_cache(**kwargs):

post_save.connect(clear_menu_cache, sender=BlogCategory)
post_delete.connect(clear_menu_cache, sender=BlogCategory)
post_delete.connect(clear_menu_cache, sender=BlogConfig)
59 changes: 59 additions & 0 deletions tests/test_menu.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from menus.menu_pool import menu_pool
from parler.utils.context import smart_override, switch_language

from djangocms_blog.cms_appconfig import BlogConfig
from djangocms_blog.models import BlogCategory
from djangocms_blog.settings import (
MENU_TYPE_CATEGORIES, MENU_TYPE_COMPLETE, MENU_TYPE_NONE, MENU_TYPE_POSTS,
Expand All @@ -30,6 +31,64 @@ def setUp(self):
activate('en')
self._reload_menus()

def test_menu_cache_clear_blogconfig(self):
"""
Tests if menu cache is cleared after config deletion
"""

from menus.models import CacheKey
from django.core.cache import cache
pages = self.get_pages()
self.get_posts()
self.reload_urlconf()

app_config_test = BlogConfig.objects.create(namespace='test_config')
app_config_test.app_title = 'appx'
app_config_test.object_name = 'Blogx'
app_config_test.save()
lang = 'en'
with smart_override(lang):
self._reset_menus()
request = self.get_page_request(pages[1], self.user, pages[1].get_absolute_url(lang), edit=True)
self.get_nodes(menu_pool, request)
keys = CacheKey.objects.get_keys().distinct().values_list('key', flat=True)
self.assertTrue(cache.get_many(keys))
app_config_test.delete()
self.assertFalse(cache.get_many(keys))

def test_menu_cache_clear_category(self):
"""
Tests if menu cache is cleared after category deletion
"""

from menus.models import CacheKey
from django.core.cache import cache
pages = self.get_pages()
self.get_posts()
self.reload_urlconf()

lang = 'en'
with smart_override(lang):
self._reset_menus()
request = self.get_page_request(pages[1], self.user, pages[1].get_absolute_url(lang), edit=True)
self.get_nodes(menu_pool, request)
keys = CacheKey.objects.get_keys().distinct().values_list('key', flat=True)
self.assertTrue(cache.get_many(keys))
category_test = BlogCategory.objects.create(
name='category test', app_config=self.app_config_1
)
category_test.set_current_language('it', initialize=True)
category_test.name = 'categoria test'
category_test.save()
self.assertFalse(cache.get_many(keys))
self.get_nodes(menu_pool, request)
keys = CacheKey.objects.get_keys().distinct().values_list('key', flat=True)
self.assertTrue(cache.get_many(keys))
category_test.delete()
self.assertFalse(cache.get_many(keys))
keys = CacheKey.objects.get_keys().distinct().values_list('key', flat=True)
self.assertFalse(keys)

def test_menu_nodes(self):
"""
Tests if all categories are present in the menu
Expand Down