Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use menu_empty_categories config for BlogCategoryPlugin #498

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Use menu_empty_categories config for BlogCategoryPlugin #498

merged 1 commit into from
Aug 5, 2019

Conversation

yakky
Copy link
Member

@yakky yakky commented Aug 4, 2019

This aligns the behavior of BlogCategoryPlugin with the menu, as most editors don't care about the difference between the categories pulled by the menu and the ones from the plugin: if menu_empty_categories is set to False in the related BlogConfig, categories without posts are hidden in the BlogCategoryPlugin

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 95.846% when pulling 0409a6f on feature/empty-categories-plugin into 77da018 on release/0.9.x.

protoroto
protoroto approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@protoroto protoroto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the sanest behaviour for the BlogCategoryPlugin plugin, as ther's no need to keep two different behaviours between the menu and the plugin.

@yakky yakky merged commit bfcc3b5 into release/0.9.x Aug 5, 2019
yakky added a commit that referenced this pull request Aug 6, 2019
@yakky
Forward port changes from 0.9 branch (#499)
cf70989 
* Pin dependencies (#496)
* Use menu_empty_categories config for BlogCategoryPlugin (#498)
* Empty menu cache when deleting blogconfig instances (#497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protoroto protoroto protoroto approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yakky @coveralls @protoroto