Fix error when overriding templates folder #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a template_prefix has been set in the blog app_config, any plugin will cause a TemplateDoesNotExist exception unless the entire template directory is copied. You will see: Exception Type: TemplateDoesNotExist at /about/jobs/ Exception Value: djangocms_blog/jobs/plugins/latest_entries.html This commit refactors get_rendor_template in BlogPlugin to use the django loader select_template method to first look for an override then default to the base version of the plugin.
Codecov Report
@@ Coverage Diff @@
## develop #562 +/- ##
===========================================
+ Coverage 92.79% 92.98% +0.19%
===========================================
Files 24 24
Lines 1041 1041
Branches 136 136
===========================================
+ Hits 966 968 +2
+ Misses 36 34 -2
Partials 39 39
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting #456
Fix #456
Fix #457