Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GA behavior on pull request #576

Merged
merged 2 commits into from May 17, 2020
Merged

Conversation

yakky
Copy link
Member

@yakky yakky commented May 17, 2020

Description

Fix current GA behavior on pull request:

  • add pullrequest event
  • fix towncrier check on GA checkout

References

Fix #575

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@yakky yakky added this to the 1.2 milestone May 17, 2020
@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #576 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #576   +/-   ##
========================================
  Coverage    93.30%   93.30%           
========================================
  Files           22       22           
  Lines         1015     1015           
  Branches       135      135           
========================================
  Hits           947      947           
  Misses          29       29           
  Partials        39       39           
Flag Coverage Δ
#unittests 93.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bb3cd...1d57f44. Read the comment docs.

@coveralls
Copy link

coveralls commented May 17, 2020

Coverage Status

Coverage remained the same at 96.14% when pulling 1d57f44 on bugfix/issue-575-pull-request-event into c5bb3cd on develop.

@yakky yakky force-pushed the bugfix/issue-575-pull-request-event branch from 3081a9f to 5fd4a0c Compare May 17, 2020 12:23
@yakky yakky changed the title Add missing pull request event to gihub actions Fix GA behavior on pull request May 17, 2020
@yakky yakky force-pushed the bugfix/issue-575-pull-request-event branch 4 times, most recently from 0ea5812 to 0ff4bb7 Compare May 17, 2020 12:51
@yakky yakky force-pushed the bugfix/issue-575-pull-request-event branch from 0ff4bb7 to 1d57f44 Compare May 17, 2020 12:54
@yakky yakky merged commit ebdefe2 into develop May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing running actions on opening pull request
2 participants