Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coveralls failure on pull request in GA #578

Merged
merged 1 commit into from
May 17, 2020

Conversation

yakky
Copy link
Member

@yakky yakky commented May 17, 2020

Description

Experimental fix for coveralls failure on GA by using coveralls action

References

Fix #577

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@yakky yakky added this to the 1.2 milestone May 17, 2020
@yakky yakky force-pushed the bugfix/issue-577-coveralls-codecov-on-pr branch from 44920bd to 0f93158 Compare May 17, 2020 18:15
@yakky yakky force-pushed the bugfix/issue-577-coveralls-codecov-on-pr branch from 0f93158 to 282d44a Compare May 17, 2020 18:27
@github-actions
Copy link

Coverage Status

Coverage remained the same at 96.14% when pulling 282d44a on bugfix/issue-577-coveralls-codecov-on-pr into ebdefe2 on develop.

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #578 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #578   +/-   ##
========================================
  Coverage    93.30%   93.30%           
========================================
  Files           22       22           
  Lines         1015     1015           
  Branches       135      135           
========================================
  Hits           947      947           
  Misses          29       29           
  Partials        39       39           
Flag Coverage Δ
#unittests 93.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebdefe2...282d44a. Read the comment docs.

@yakky yakky merged commit 1654dc9 into develop May 17, 2020
g3rb3n pushed a commit to g3rb3n/djangocms-blog that referenced this pull request May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access coveralls / codecov env variable from pull requests
1 participant