Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_auto_field to BlogAppConfig #741

Merged

Conversation

protoroto
Copy link
Member

@protoroto protoroto commented Jul 20, 2023

Description

Add default_auto_field to BlogAppConfig to get rid of Django 3.2 warnings

References

Fix #737

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto protoroto force-pushed the feature/issue-737-add-default-auto-field branch from 6b85e87 to b78c691 Compare July 20, 2023 13:16
@protoroto protoroto requested a review from yakky July 20, 2023 13:17
@protoroto protoroto force-pushed the feature/issue-737-add-default-auto-field branch from b78c691 to 14b80ba Compare July 20, 2023 13:19
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bc43947) 94.24% compared to head (14b80ba) 94.24%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #741   +/-   ##
========================================
  Coverage    94.24%   94.24%           
========================================
  Files           26       26           
  Lines         1823     1824    +1     
  Branches       260      260           
========================================
+ Hits          1718     1719    +1     
  Misses          53       53           
  Partials        52       52           
Flag Coverage Δ
unittests 94.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
djangocms_blog/apps.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coveralls
Copy link

Coverage Status

coverage: 97.094% (+0.1%) from 96.961% when pulling 14b80ba on protoroto:feature/issue-737-add-default-auto-field into bc43947 on nephila:develop.

@yakky
Copy link
Member

yakky commented Jul 21, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warnings after upgrading to django 3.2
3 participants