Skip to content

Commit

Permalink
add tests!
Browse files Browse the repository at this point in the history
*fix flake8 command in tox.ini (launch flake8 djangocms_page_meta tests)
*add tests for schemaorg properties
  • Loading branch information
corentinbettiol committed Aug 21, 2020
1 parent 947f807 commit 641f83a
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 1 deletion.
9 changes: 9 additions & 0 deletions tests/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,12 @@ class BaseTest(BaseTestCase):
'twitter_site': 'fake_site',
'twitter_type': 'summary',
}
schemaorg_data = {
'schemaorg_datePublished': 'fake_user',
'schemaorg_dateModified': 'fake_site',
'schemaorg_type': 'Article',
'schemaorg_name': 'schemaorg name - lorem ipsum',
'schemaorg_description': 'schemaorg description - lorem ipsum',
'schemaorg_image': 'https://example.com/image.png',
'schemaorg_url': 'https://example.com',
}
23 changes: 23 additions & 0 deletions tests/test_general.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,29 @@ def test_page_meta_twitter(self):
self.assertEqual(meta.twitter_type, self.twitter_data['twitter_type'])
self.assertEqual(meta.get_domain(), settings.META_SITE_DOMAIN)

def test_page_meta_schemaorg(self):
"""
Tests the Schema.org properties
"""
page, __ = self.get_pages()
page_meta = models.PageMeta.objects.create(extended_object=page)
for key, val in self.page_data.items():
setattr(page_meta, key, val)
for key, val in self.schemaorg_data.items():
setattr(page_meta, key, val)
page_meta.save()

page.reload()

meta = get_page_meta(page, 'en')
self.assertEqual(meta.schemaorg_datePublished, page.publication_date.isoformat())
self.assertEqual(meta.schemaorg_dateModified, page.changed_date.isoformat())
self.assertEqual(meta.schemaorg_type, self.schemaorg_data['schemaorg_type'])
self.assertEqual(meta.schemaorg_name, self.schemaorg_data['schemaorg_name'])
self.assertEqual(meta.schemaorg_description, self.schemaorg_data['schemaorg_description'])
self.assertEqual(meta.schemaorg_image, self.schemaorg_data['schemaorg_image'])
self.assertEqual(meta.schemaorg_url, self.schemaorg_data['schemaorg_url'])

def test_none_page(self):
meta = get_page_meta(None, 'en')
self.assertIsNone(meta)
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ deps =

[testenv:pep8]
deps = flake8
commands = flake8
commands = flake8 djangocms_page_meta tests
skip_install = true

[testenv:isort]
Expand Down

0 comments on commit 641f83a

Please sign in to comment.