Merge 2c7ca5b into 358a5f3

changes/150.bugfix

@@ -0,0 +1 @@
+Skip creating toolbar item in page types

djangocms_page_meta/cms_toolbars.py

@@ -28,6 +28,9 @@ def populate(self):
         if not self.page:
             # Nothing to do
             return
+        if self.page.is_page_type:
+            # we don't need this on page types
+            return
 
         # check global permissions if CMS_PERMISSIONS is active
         if get_cms_setting("PERMISSION"):

tests/test_toolbar.py

@@ -41,6 +41,24 @@ def test_no_perm(self):
             meta_menu = page_menu[0].item.find_items(SubMenu, name=force_str(PAGE_META_MENU_TITLE))
             self.assertEqual(meta_menu, [])
 
+    def test_page_types(self):
+        """
+        Test that page meta menu is not displayed on page types.
+        """
+        from cms.toolbar.toolbar import CMSToolbar
+
+        page1, __ = self.get_pages()
+        page1.is_page_type = True
+        page1.save()
+        self.user_staff.user_permissions.add(Permission.objects.get(codename="change_page"))
+        self.user_staff = User.objects.get(pk=self.user_staff.pk)
+        request = self.get_page_request(page1, self.user_staff, "/", edit=True)
+        toolbar = CMSToolbar(request)
+        toolbar.get_left_items()
+        page_menu = toolbar.menus["page"]
+        page_items = page_menu.find_items(SubMenu, name=force_str(PAGE_META_MENU_TITLE))
+        self.assertEqual(len(page_items), 0)
+
     def test_perm(self):
         """
         Test that page meta menu is present if user has Page.change_perm