Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robots meta #165

Merged

Conversation

protoroto
Copy link
Member

@protoroto protoroto commented Aug 3, 2023

Description

Add robots meta

Original pr from @corentinbettiol

References

Fixes #116

Fix #131

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@coveralls
Copy link

coveralls commented Aug 3, 2023

Coverage Status

coverage: 93.798% (+0.3%) from 93.46% when pulling 6a1dada on protoroto:feature/issue-116-add-meta-robots into ef53f1f on nephila:develop.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 95.45% and project coverage change: +0.26% 🎉

Comparison is base (ef53f1f) 89.91% compared to head (6a1dada) 90.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
+ Coverage    89.91%   90.18%   +0.26%     
===========================================
  Files            9        9              
  Lines          367      387      +20     
  Branches        55       58       +3     
===========================================
+ Hits           330      349      +19     
  Misses          24       24              
- Partials        13       14       +1     
Flag Coverage Δ
unittests 90.18% <95.45%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
djangocms_page_meta/forms.py 89.28% <90.00%> (-0.19%) ⬇️
djangocms_page_meta/admin.py 95.45% <100.00%> (+0.10%) ⬆️
djangocms_page_meta/models.py 92.72% <100.00%> (+0.49%) ⬆️
djangocms_page_meta/settings.py 100.00% <100.00%> (ø)
djangocms_page_meta/utils.py 81.81% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto force-pushed the feature/issue-116-add-meta-robots branch 2 times, most recently from 7caa375 to 9a9cd5d Compare August 3, 2023 15:10
Co-authored-by: corentinbettiol <cb@kapt.mobi>
@protoroto protoroto force-pushed the feature/issue-116-add-meta-robots branch from 9a9cd5d to 6a1dada Compare August 3, 2023 15:25
@protoroto protoroto requested a review from yakky August 3, 2023 15:34
djangocms_page_meta/models.py Show resolved Hide resolved
@protoroto protoroto merged commit c95e627 into nephila:develop Aug 7, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managing robots meta tag in djangocms-page-meta
3 participants