Prevent blank keywords from overwriting default #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the META_DEFAULT_KEYWORDS setting, defaults would be overwritten by a TitleMeta object with a blank keyword list. The end result being that a user could never go back to using default keywords if they blanked out the field.
Default page title should come from `page.get_page_title`, not `page.get_title` as djangocms page title hint says "Overwrites what is displayed at the top of your browser or in bookmarks".
|
Also added a commit about page title defaulting to page.page_title instead of (still falls back to page.title). |
|
Thanks! |
yakky
added a commit
that referenced
this pull request
Jul 23, 2014
Prevent blank keywords from overwriting default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the META_DEFAULT_KEYWORDS setting, defaults would be overwritten by a TitleMeta object with a blank keyword list. The end result being that a user could never go back to using default keywords if they blanked out the field.
Sorry, I don't know how to write the tests for this, but it's a simple patch.