Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug print statements #67

Conversation

Sillocan
Copy link
Contributor

@Sillocan Sillocan commented Aug 4, 2023

Description

Describe:

  • Removes debug print statements.
  • Print statements were left in which pollutes stdout for users. This breaks tests of users which use regex to find matching strings in stdout.

References

Fix #66

Checklist

  • Code lint checked via inv lint
  • Tests added

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@d48b79b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   94.17%           
=========================================
  Files             ?       12           
  Lines             ?      223           
  Branches          ?       48           
=========================================
  Hits              ?      210           
  Misses            ?       10           
  Partials          ?        3           
Flag Coverage Δ
unittests 94.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sillocan Sillocan mentioned this pull request Aug 4, 2023
2 tasks
@protoroto
Copy link
Member

Thanks @Sillocan :)

@protoroto protoroto merged commit be53ca8 into nephila:master Aug 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version causes lots of data to go to stdout
2 participants