Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #114 #115

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Fix for issue #114 #115

merged 3 commits into from
Apr 23, 2023

Conversation

uc-cjdavis
Copy link
Contributor

@uc-cjdavis uc-cjdavis commented Oct 12, 2021

Description

Describe:

Updates tests/resources/auth_user_success.json file to add support for the refresh token
Adds support in client.py for the returned refresh token.

References

Fixes bug #114

Checklist

  • I have read the contribution guide

  • Code lint checked via inv lint

  • changes file included (see docs)

  • Usage documentation added in case of new features

  • Tests added*

  • tests tox -e py3.9 and inv lint run locally

@uc-cjdavis
Copy link
Contributor Author

cc @astagi and @yakky

@uc-cjdavis
Copy link
Contributor Author

Also cc @erikw

@coveralls
Copy link

coveralls commented Oct 23, 2021

Coverage Status

Coverage increased (+0.002%) to 97.826% when pulling d015a5c on uc-cjdavis:master into 71888dd on nephila:master.

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (284f825) 96.38% compared to head (b2bd5cb) 96.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files           8        8           
  Lines         884      885    +1     
  Branches       66       66           
=======================================
+ Hits          852      853    +1     
  Misses         19       19           
  Partials       13       13           
Flag Coverage Δ
unittests 96.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
taiga/client.py 90.47% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yakky
Copy link
Member

yakky commented Oct 23, 2021

@uc-cjdavis thanks for this submission, I see it only includes the json change, not the client.py change to actually support the refresh_token
Are you going to add it in this PR?
I will take care of fixing the unrelated linting issues

@uc-cjdavis
Copy link
Contributor Author

uc-cjdavis commented Oct 25, 2021

@uc-cjdavis thanks for this submission, I see it only includes the json change, not the client.py change to actually support the refresh_token Are you going to add it in this PR? I will take care of fixing the unrelated linting issues

@yakky I'd planned to add refresh_token support in a separate PR since it relies on a successful test with this change in place; it's ready to go once this is approved/merged.

@yakky
Copy link
Member

yakky commented Oct 25, 2021

@uc-cjdavis I think it's easier if you wrap everything in a single pull request: the test will be fixed anyway and it will make review easier

@uc-cjdavis
Copy link
Contributor Author

@yakky Okay...I'll comment here once the PR is updated.

@uc-cjdavis
Copy link
Contributor Author

@yakky PR updated.
How should I handle the changes/114.bugfix file, since I'm technically adding a feature?
Or could this be considered a bugfix?

@uc-cjdavis
Copy link
Contributor Author

@yakky Two questions:

  1. Is there anything else needed for this PR before it can be merged?
  2. In working with token_refresh in my branch, I realized that in order to use it properly the raw_request class attribute has to be somehow updated with the new auth and refresh tokens without calling client.auth() again. I can cobble together a function but it may take some time...should this PR be updated or a new one created?

@yakky
Copy link
Member

yakky commented Apr 23, 2023

@uc-cjdavis sorry, my bad. I have been away from the package for a while and this went unmerged.

Thanks a lot for your work

@yakky yakky merged commit 438dbb5 into nephila:master Apr 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants