-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #114 #115
Fix for issue #114 #115
Conversation
Also cc @erikw |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 8 8
Lines 884 885 +1
Branches 66 66
=======================================
+ Hits 852 853 +1
Misses 19 19
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@uc-cjdavis thanks for this submission, I see it only includes the json change, not the client.py change to actually support the refresh_token |
@yakky I'd planned to add refresh_token support in a separate PR since it relies on a successful test with this change in place; it's ready to go once this is approved/merged. |
@uc-cjdavis I think it's easier if you wrap everything in a single pull request: the test will be fixed anyway and it will make review easier |
@yakky Okay...I'll comment here once the PR is updated. |
@yakky PR updated. |
@yakky Two questions:
|
@uc-cjdavis sorry, my bad. I have been away from the package for a while and this went unmerged. Thanks a lot for your work |
Description
Describe:
Updates tests/resources/auth_user_success.json file to add support for the
refresh
tokenAdds support in
client.py
for the returnedrefresh
token.References
Fixes bug #114
Checklist
I have read the contribution guide
Code lint checked via
inv lint
changes
file included (see docs)Usage documentation added in case of new features
Tests added*
tests
tox -e py3.9
andinv lint
run locally