Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAI-Blueprint Changes for O1-Telnet #41

Merged
merged 4 commits into from
Jul 2, 2024
Merged

OAI-Blueprint Changes for O1-Telnet #41

merged 4 commits into from
Jul 2, 2024

Conversation

jain-ashish-sam
Copy link
Contributor

No description provided.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong June 13, 2024 21:45
@liamfallon
Copy link
Member

@arora-sagar Would you mind taking a look at this one?

@arora-sagar arora-sagar requested review from arora-sagar and removed request for s3wong June 27, 2024 13:09
@arora-sagar
Copy link
Contributor

@liamfallon I am fine with this, I am waiting for @jain-ashish-sam to put the end-to-end testing results here and then we can merge it.

@jain-ashish-sam
Copy link
Contributor Author

Waiting for OAI-operator to get tagged, so that we can refer the tagged image in oai-ran-operator blueprint.

arora-sagar
arora-sagar reviewed Jul 1, 2024
View reviewed changes
workloads/oai/pkg-example-cucp-bp/config_ran_nf.yaml
image: "arorasagar/testing-images:oai-gnb-telnet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jain-ashish-sam Can you add a note saying that this image is temporary and later it will be changed? Since this is a personal repository?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!!

@arora-sagar
Copy link
Contributor

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jul 1, 2024
@tliron
Copy link
Contributor

tliron commented Jul 2, 2024

/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arora-sagar, jain-ashish-sam, tliron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 2, 2024
@nephio-prow nephio-prow bot merged commit af9ca57 into nephio-project:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arora-sagar arora-sagar arora-sagar left review comments

@henderiw henderiw Awaiting requested review from henderiw

Assignees

@arora-sagar arora-sagar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
4 participants
@jain-ashish-sam @liamfallon @arora-sagar @tliron