Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting steps in the exercises #106

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

arora-sagar
Copy link
Contributor

  • Adding metallb ip-address pool creation
  • Removing the extra white spaces from network diagram

@gvbalaji
Copy link
Contributor

gvbalaji commented Feb 5, 2024

/lgtm
/approve

@nephio-prow nephio-prow bot removed the lgtm label Feb 5, 2024
@arora-sagar arora-sagar requested review from tliron and removed request for johnbelamaric February 5, 2024 16:30
@tliron
Copy link
Contributor

tliron commented Feb 5, 2024

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Feb 5, 2024
Copy link
Contributor

nephio-prow bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gvbalaji, tliron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 5, 2024
@nephio-prow nephio-prow bot merged commit 9b3cf60 into nephio-project:main Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants