Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version support for R3 #139

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

Partially fixes: nephio-project/nephio#738

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@nephio-prow nephio-prow bot requested review from s3wong and tliron June 17, 2024 13:14
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for nephio-r3 ready!

Name Link
🔨 Latest commit 0d9c5b8
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r3/deploys/667036c43a4e090008be5747
😎 Deploy Preview https://deploy-preview-139--nephio-r3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CsatariGergely
Copy link
Contributor Author

/assign @efiacor @liamfallon

@liamfallon
Copy link
Member

When I click R3 on the releases dropdown tab, and go to the "R3" page, the releases dropdown disappears, see below.
Screenshot 2024-06-17 at 15 09 32

See below:

Screenshot 2024-06-17 at 15 09 42

@CsatariGergely
Copy link
Contributor Author

When I click R3 on the releases dropdown tab, and go to the "R3" page, the releases dropdown disappears, see below. Screenshot 2024-06-17 at 15 09 32

See below:

Screenshot 2024-06-17 at 15 09 42

Haha, yes, that is a chicken and egg problem. When you click the R3 in the drop-down you get to the deployed R3 documentation and that does not have the drop-down yet because this pr is not merged :)

@liamfallon
Copy link
Member

When I click R3 on the releases dropdown tab, and go to the "R3" page, the releases dropdown disappears, see below. Screenshot 2024-06-17 at 15 09 32
See below:
Screenshot 2024-06-17 at 15 09 42

Haha, yes, that is a chicken and egg problem. When you click the R3 in the drop-down you get to the deployed R3 documentation and that does not have the drop-down yet because this pr is not merged :)

OK, that's fine.

@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 19, 2024
Copy link
Contributor

nephio-prow bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 19, 2024
@nephio-prow nephio-prow bot merged commit b604091 into nephio-project:R3 Jun 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants