Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Controller user's guide #77

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Adding Controller user's guide #77

merged 7 commits into from
Jan 31, 2024
+85 −0

Conversation

CsatariGergely
Copy link
Contributor

No description provided.

@CsatariGergely
Adding Controller user's guide
7d7c74f 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 12, 2024

Hi @CsatariGergely. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

efiacor
efiacor reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

content/en/docs/guides/user-guides/controllers.md Outdated Show resolved Hide resolved
content/en/docs/guides/user-guides/controllers.md Outdated Show resolved Hide resolved
content/en/docs/guides/user-guides/controllers.md Outdated Show resolved Hide resolved
content/en/docs/guides/user-guides/controllers.md Outdated Show resolved Hide resolved
content/en/docs/guides/user-guides/controllers.md Outdated Show resolved Hide resolved
@efiacor efiacor mentioned this pull request Jan 15, 2024
Merged
@CsatariGergely
Reformatting deployment checking command
afd20ba 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
nephio-prow bot pushed a commit that referenced this pull request Jan 19, 2024
@efiacor
Fix broken hyperlinks (#80)
b9e120e 
Fix some broken internal links.


* Learn more about the Nephio

[controllers](https://github.com/nephio-project/docs/blob/main/user-guide/controllers.md)

The above link is dependent on this PR being merged:
#77
CsatariGergely and others added 2 commits January 24, 2024 17:12
@CsatariGergely @efiacor
Apply suggestions from code review
677bf45 
Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
@CsatariGergely
Fixing environment variable name
9b070b4 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Contributor Author

/assign @johnbelamaric
/assign @tliron
/assign @efiacor

@liamfallon
Copy link
Member

/ok-to-test

CsatariGergely and others added 3 commits January 26, 2024 09:50
@CsatariGergely @liamfallon
Update content/en/docs/guides/user-guides/controllers.md
818c756 
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
@CsatariGergely
Clarifications about the reconcilier interface
1cc43ea 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Merge branch 'add-controller-guide' of github.com:nokia/nephio-docs i…
8f19d0a 
…nto add-controller-guide
@liamfallon
Copy link
Member

/approve

@nephio-prow nephio-prow bot added the approved label Jan 26, 2024
@CsatariGergely CsatariGergely mentioned this pull request Jan 31, 2024
Merged
@efiacor
Copy link
Contributor

efiacor commented Jan 31, 2024

/approve

@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 31, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 60878b4 into nephio-project:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiacor efiacor efiacor left review comments

@liamfallon liamfallon liamfallon approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@tliron tliron Awaiting requested review from tliron

Assignees

@tliron tliron

@johnbelamaric johnbelamaric

@liamfallon liamfallon

@efiacor efiacor

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
5 participants
@CsatariGergely @liamfallon @efiacor @tliron @johnbelamaric