Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some broken links of docs #86

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

ntnguyencse
Copy link
Contributor

I'm learning and researching about the Nephio project, but I have some problems with outdated docs.

@nephio-prow nephio-prow bot requested review from henderiw and tliron January 19, 2024 02:13
Copy link

linux-foundation-easycla bot commented Jan 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

nephio-prow bot commented Jan 19, 2024

Hi @ntnguyencse. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

nephio-prow bot commented Jan 19, 2024

@ntnguyencse: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CsatariGergely
Copy link
Contributor

Thanks for the corrections. We are in the process to move the rendered documentation from GitHub to Netifly, when we are done we will need to update these links with the final URL of the documents, but for now these are the correct ones.

@ntnguyencse
Copy link
Contributor Author

Hi @CsatariGergely, I understand that it is temporary. Please continue to merge the pull request.

@liamfallon
Copy link
Member

/ok-to-test

@liamfallon
Copy link
Member

/approve
/lgtm

@ntnguyencse
Copy link
Contributor Author

ntnguyencse commented Jan 20, 2024

/assign @s3wong
please approve and lgtm

@liamfallon
Copy link
Member

/lgtm
/approve

Copy link
Member

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CsatariGergely there is a GitHub Action that we can use to validate the links, do you like to include it?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
@nephio-prow nephio-prow bot removed the lgtm label Jan 23, 2024
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
@CsatariGergely
Copy link
Contributor

@CsatariGergely there is a GitHub Action that we can use to validate the links, do you like to include it?

Sure we can add it, but for most of the links we are using the "Hugo style" links for what we will need just an other GitHub action :) (https://github.com/marketplace/actions/hugo-broken-link-check)

@liamfallon
Copy link
Member

Can we pull this PR in and maybe add the Github actions later? This PR fixes the developer guide and install guide links.

@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 23, 2024
@electrocucaracha
Copy link
Member

/lgtm

@liamfallon
Copy link
Member

/lgtm
/approve

@gvbalaji
Copy link
Contributor

/assign @s3wong @tliron

@henderiw
Copy link
Contributor

/approve

Copy link
Contributor

nephio-prow bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CsatariGergely, henderiw, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jan 24, 2024
@nephio-prow nephio-prow bot merged commit 112b258 into nephio-project:main Jan 24, 2024
3 checks passed
@liamfallon
Copy link
Member

thanks @henderiw !

@ntnguyencse
Copy link
Contributor Author

ntnguyencse commented Jan 24, 2024

Thanks @henderiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants