-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some broken links of docs #86
Conversation
Hi @ntnguyencse. Thanks for your PR. I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ntnguyencse: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the corrections. We are in the process to move the rendered documentation from GitHub to Netifly, when we are done we will need to update these links with the final URL of the documents, but for now these are the correct ones. |
Hi @CsatariGergely, I understand that it is temporary. Please continue to merge the pull request. |
/ok-to-test |
/approve |
/assign @s3wong |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CsatariGergely there is a GitHub Action that we can use to validate the links, do you like to include it?
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Sure we can add it, but for most of the links we are using the "Hugo style" links for what we will need just an other GitHub action :) (https://github.com/marketplace/actions/hugo-broken-link-check) |
Can we pull this PR in and maybe add the Github actions later? This PR fixes the developer guide and install guide links. |
/lgtm |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CsatariGergely, henderiw, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @henderiw ! |
Thanks @henderiw |
I'm learning and researching about the Nephio project, but I have some problems with outdated docs.