Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert inadvertent check in of file to documentation #93

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

liamfallon
Copy link
Member

The developer guide has already been moved to to content/en/docs/guides/contributor-guides. It was inadvertently added in PR-92 and should be deleted here.

@liamfallon
Copy link
Member Author

/assign @tliron

@CsatariGergely
Copy link
Contributor

Good catch.
The mockery related description is missing from the content/en/docs/guides/contributor-guides version. Is mockery not used anymore?

@CsatariGergely
Copy link
Contributor

Can you add a bit more descriptive name to the pr?

Copy link
Contributor

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@efiacor
Copy link
Contributor

efiacor commented Jan 25, 2024

/assign @liamfallon

@CsatariGergely
Copy link
Contributor

CsatariGergely commented Jan 25, 2024

Good catch. The mockery related description is missing from the content/en/docs/guides/contributor-guides version. Is mockery not used anymore?

I've just learned from @kispaljr that mockery is still used but I could not find the referred file even in the history (git reflog --diff-filter D --pretty="format:" --name-only | grep mockery) what I think the reason why the section referring to it was removed.

All in all it is ok to delete the file.

@liamfallon
Copy link
Member Author

Good catch. The mockery related description is missing from the content/en/docs/guides/contributor-guides version. Is mockery not used anymore?

Well it was my error that it was included. Yes Mockery is being used but I checked in a preliminary version of Mockery instructions that I'm working on. It's not ready to be merged yet.

@liamfallon liamfallon changed the title . Revert inadvertent check in of file to documentation Jan 25, 2024
@liamfallon
Copy link
Member Author

Can you add a bit more descriptive name to the pr?

Done

@liamfallon
Copy link
Member Author

Good catch. The mockery related description is missing from the content/en/docs/guides/contributor-guides version. Is mockery not used anymore?

I've just learned from @kispaljr that mockery is still used but I could not find the referred file even in the history (git reflog --diff-filter D --pretty="format:" --name-only | grep mockery) what I think the reason why the section referring to it was removed.

All in all it is ok to delete the file.

I will add the Mockery description in a few days when I get a chance to add/edit the text properly.

@efiacor
Copy link
Contributor

efiacor commented Jan 26, 2024

/approve

Copy link
Contributor

nephio-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CsatariGergely, efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jan 26, 2024
@nephio-prow nephio-prow bot merged commit 2d9a3f3 into nephio-project:main Jan 26, 2024
2 of 3 checks passed
@liamfallon liamfallon deleted the revert-developer-guide branch January 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants