Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E testing : Deploy free5gc operator on workload cluster using Nephio #237

Closed
Tracked by #234
gvbalaji opened this issue May 30, 2023 · 7 comments · Fixed by nephio-project/free5gc-packages#19
Closed
Tracked by #234

E2E testing : Deploy free5gc operator on workload cluster using Nephio #237

gvbalaji opened this issue May 30, 2023 · 7 comments · Fixed by nephio-project/free5gc-packages#19
Assignees
@SimonTheLeg
Labels
area/package-management SIG Automation Package Management Subproject sig/automation
Milestone
sprint5

Comments

@gvbalaji
Copy link

gvbalaji commented May 30, 2023 •
edited
Loading

Make sure all pods are up and running
@gvbalaji gvbalaji mentioned this issue May 30, 2023
Closed
12 tasks
@gvbalaji gvbalaji added area/package-management SIG Automation Package Management Subproject sig/automation labels May 30, 2023
@gvbalaji gvbalaji added this to the sprint5 milestone May 30, 2023
@johnbelamaric
Copy link
Member

Need:

  • an image with the operator
  • a kpt pkg with all the manifests to deploy the operator

Then we just need a PVS to distribute this.

@johnbelamaric
Copy link
Member

@n2vo will follow up and create issues / assign to the right people

@johnbelamaric
Copy link
Member

@tliron will manually build and push free5gc-operator image

@tliron
Copy link

tliron commented Jun 2, 2023

See here.

@gvbalaji gvbalaji changed the title Deploy free5gc operator on workload cluster using Nephio E2E testing : Deploy free5gc operator on workload cluster using Nephio Jun 5, 2023
@SimonTheLeg SimonTheLeg mentioned this issue Jun 6, 2023
Merged
nephio-prow bot pushed a commit to nephio-project/free5gc-packages that referenced this issue Jun 9, 2023
@SimonTheLeg
Kpt package for free5gc operator (#19)
97b10cf 
fixes: nephio-project/nephio#237

`kpt live apply` results in the following output, which looks good to me

```log
+ free5gc-operator-controller-controller-5f564b9575-9zqh8 › kube-rbac-proxy
+ free5gc-operator-controller-controller-5f564b9575-9zqh8 › controller
controller 2023-06-06T08:14:19Z INFO    controller-runtime.metrics      Metrics server is starting to listen    {"addr": "127.0.0.1:8080"}
controller 2023-06-06T08:14:19Z INFO    setup   starting manager
controller 2023-06-06T08:14:19Z INFO    Starting server {"kind": "health probe", "addr": "[::]:8081"}
controller 2023-06-06T08:14:19Z INFO    Starting server {"path": "/metrics", "kind": "metrics", "addr": "127.0.0.1:8080"}
controller I0606 08:14:19.021197       1 leaderelection.go:248] attempting to acquire leader lease free5gc/5089c67f.nephio.org...
kube-rbac-proxy I0605 15:21:41.317844       1 main.go:190] Valid token audiences:
kube-rbac-proxy I0605 15:21:41.317923       1 main.go:262] Generating self signed cert as no cert is provided
kube-rbac-proxy I0605 15:21:42.248182       1 main.go:311] Starting TCP socket on 0.0.0.0:8443
kube-rbac-proxy I0605 15:21:42.299794       1 main.go:318] Listening securely on 0.0.0.0:8443
controller I0606 08:14:35.806293       1 leaderelection.go:258] successfully acquired lease free5gc/5089c67f.nephio.org
controller 2023-06-06T08:14:35Z DEBUG   events  free5gc-operator-controller-controller-5f564b9575-9zqh8_7ef3c0e9-dbd2-4324-832d-4eb9609dd0af became leader      {"type": "Normal", "object": {"kind":"Lease","namespace":"free5gc","name":"5089c67f.nephio.org","uid":"0c1c0eb7-cb7b-44c9-8a73-fac80301057e","apiVersion":"coordination.k8s.io/v1","resourceVersion":"78088"}, "reason": "LeaderElection"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "source": "kind source: *v1alpha1.UPFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "source": "kind source: *v1.Deployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "source": "kind source: *v1.ConfigMap"}
controller 2023-06-06T08:14:35Z INFO    Starting Controller     {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "source": "kind source: *v1alpha1.AMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "source": "kind source: *v1alpha1.SMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "source": "kind source: *v1.Deployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "source": "kind source: *v1.Deployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "source": "kind source: *v1.ConfigMap"}
controller 2023-06-06T08:14:35Z INFO    Starting Controller     {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "source": "kind source: *v1.ConfigMap"}
controller 2023-06-06T08:14:35Z INFO    Starting Controller     {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting workers        {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "worker count": 1}
controller 2023-06-06T08:14:35Z INFO    Starting workers        {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "worker count": 1}
controller 2023-06-06T08:14:35Z INFO    Starting workers        {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "worker count": 1}

```

Open questions from my side:
1. Would it make sense to rename the component from
"free5gc-operator-controller" to "free5gc-operator"? I think this would
also shorten object names which are sometimes
`free5gc-operator-controller-controller-controller-role` to be more
readable and don't stutter.
2. Since one major principal behind kpt is configuration as data, what
should the default for `app.kubernetes.io/version` be? Can we just
`main` since using it from source will always be a dev state?
3. What is the correct way to handle namespace? Without adding it as a
resource (see b343641), the following error occurs 'error: task failed
(action: "Inventory", name: "inventory-add-0"): namespaces "free5gc" not
found'
@johnbelamaric johnbelamaric reopened this Jun 9, 2023
@johnbelamaric
Copy link
Member

johnbelamaric commented Jun 9, 2023 •
edited
Loading

Not quite done. Needs:

@johnbelamaric
Copy link
Member

Ok, with the latest checkins I tried nephio-project/test-infra#76 and it worked, so as soon as that merges we can mark this done.

@johnbelamaric
Copy link
Member

That's merged, I tested it and it is working.

denysaleksandrov pushed a commit to denysaleksandrov/free5gc-packages that referenced this issue Jun 12, 2023
@SimonTheLeg @denysaleksandrov
Kpt package for free5gc operator (nephio-project#19)
d2dfaf1 
fixes: nephio-project/nephio#237

`kpt live apply` results in the following output, which looks good to me

```log
+ free5gc-operator-controller-controller-5f564b9575-9zqh8 › kube-rbac-proxy
+ free5gc-operator-controller-controller-5f564b9575-9zqh8 › controller
controller 2023-06-06T08:14:19Z INFO    controller-runtime.metrics      Metrics server is starting to listen    {"addr": "127.0.0.1:8080"}
controller 2023-06-06T08:14:19Z INFO    setup   starting manager
controller 2023-06-06T08:14:19Z INFO    Starting server {"kind": "health probe", "addr": "[::]:8081"}
controller 2023-06-06T08:14:19Z INFO    Starting server {"path": "/metrics", "kind": "metrics", "addr": "127.0.0.1:8080"}
controller I0606 08:14:19.021197       1 leaderelection.go:248] attempting to acquire leader lease free5gc/5089c67f.nephio.org...
kube-rbac-proxy I0605 15:21:41.317844       1 main.go:190] Valid token audiences:
kube-rbac-proxy I0605 15:21:41.317923       1 main.go:262] Generating self signed cert as no cert is provided
kube-rbac-proxy I0605 15:21:42.248182       1 main.go:311] Starting TCP socket on 0.0.0.0:8443
kube-rbac-proxy I0605 15:21:42.299794       1 main.go:318] Listening securely on 0.0.0.0:8443
controller I0606 08:14:35.806293       1 leaderelection.go:258] successfully acquired lease free5gc/5089c67f.nephio.org
controller 2023-06-06T08:14:35Z DEBUG   events  free5gc-operator-controller-controller-5f564b9575-9zqh8_7ef3c0e9-dbd2-4324-832d-4eb9609dd0af became leader      {"type": "Normal", "object": {"kind":"Lease","namespace":"free5gc","name":"5089c67f.nephio.org","uid":"0c1c0eb7-cb7b-44c9-8a73-fac80301057e","apiVersion":"coordination.k8s.io/v1","resourceVersion":"78088"}, "reason": "LeaderElection"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "source": "kind source: *v1alpha1.UPFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "source": "kind source: *v1.Deployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "source": "kind source: *v1.ConfigMap"}
controller 2023-06-06T08:14:35Z INFO    Starting Controller     {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "source": "kind source: *v1alpha1.AMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "source": "kind source: *v1alpha1.SMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "source": "kind source: *v1.Deployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "source": "kind source: *v1.Deployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "source": "kind source: *v1.ConfigMap"}
controller 2023-06-06T08:14:35Z INFO    Starting Controller     {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting EventSource    {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "source": "kind source: *v1.ConfigMap"}
controller 2023-06-06T08:14:35Z INFO    Starting Controller     {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment"}
controller 2023-06-06T08:14:35Z INFO    Starting workers        {"controller": "upfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "UPFDeployment", "worker count": 1}
controller 2023-06-06T08:14:35Z INFO    Starting workers        {"controller": "amfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "AMFDeployment", "worker count": 1}
controller 2023-06-06T08:14:35Z INFO    Starting workers        {"controller": "smfdeployment", "controllerGroup": "workload.nephio.org", "controllerKind": "SMFDeployment", "worker count": 1}

```

Open questions from my side:
1. Would it make sense to rename the component from
"free5gc-operator-controller" to "free5gc-operator"? I think this would
also shorten object names which are sometimes
`free5gc-operator-controller-controller-controller-role` to be more
readable and don't stutter.
2. Since one major principal behind kpt is configuration as data, what
should the default for `app.kubernetes.io/version` be? Can we just
`main` since using it from source will always be a dev state?
3. What is the correct way to handle namespace? Without adding it as a
resource (see b343641), the following error occurs 'error: task failed
(action: "Inventory", name: "inventory-add-0"): namespaces "free5gc" not
found'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonTheLeg SimonTheLeg

Labels
area/package-management SIG Automation Package Management Subproject sig/automation
Projects
Nephio R1
Status: Done
Milestone
sprint5
Development

Successfully merging a pull request may close this issue.

Kpt package for free5gc operator SimonTheLeg/nephio-free5gc-packages
5 participants
@tliron @denysaleksandrov @gvbalaji @johnbelamaric @SimonTheLeg