Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approval-controller: check packagevariant conditions #251

Closed
johnbelamaric opened this issue Jun 1, 2023 · 0 comments · Fixed by #252
Closed

approval-controller: check packagevariant conditions #251

johnbelamaric opened this issue Jun 1, 2023 · 0 comments · Fixed by #252

Comments

@johnbelamaric
Copy link
Member

The auto-approval controller should check the PV conditions, if the package revision is owned by a package variant, and not approve if the PV is not ready. A not-ready PV means that it was not able to generate the draft.

This should also be mitigated by implementing kptdev/kpt#3979 upstream. However, even that is not sufficient, since the "clone and mutate" done by PV is not atomic.
This was referenced Jun 1, 2023
Merged
Closed
Merged
nephio-prow bot pushed a commit that referenced this issue Jun 2, 2023
@johnbelamaric
Approval controller fixes (#252)
0459821 
- Increase the default delay to two minutes
- Check the Ready status of the owning PackageVariant

Along with
nephio-project/nephio-example-packages#42 this
should:

Fixes #248
Fixes #249
Fixes #251
@nephio-prow nephio-prow bot closed this as completed in #252 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Approval controller fixes johnbelamaric/nephio
1 participant
@johnbelamaric