Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replace in go.mod #253

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

johnbelamaric
Copy link
Member

In order for the automated docker build to work, we need to comment out the replace line.

Merging this will trigger the docker build and push the image to our registry.

Alternatively, instead of merging this we can any of these:

  • Manually build and push
  • Fix the docker build in the nephio-controller-manager to copy in the entire controllers directory and tweak the replace statement
  • Figure out something better than the way we do our multiple go.mod files right now

@nephio-prow nephio-prow bot requested review from s3wong and tliron June 2, 2023 04:40
@johnbelamaric
Copy link
Member Author

The point is, any PR that merges that touches the controllers/pkg (like #252 for example) needs a sort of double-commit like this, once to get the pkg directory into github, then once to consume that from github rather than from the replace. Which is a pain.

@henderiw
Copy link
Contributor

henderiw commented Jun 2, 2023

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 2, 2023
@nephio-prow nephio-prow bot merged commit 50adad6 into nephio-project:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants