Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing the check of env value #423

Merged
merged 2 commits into from Nov 6, 2023

Conversation

rravindran123
Copy link
Contributor

This PR checks the value of the Environmental value in addition to just checking its definition as it is currently implemented.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong October 24, 2023 00:07
@johnbelamaric
Copy link
Member

/approve

yes, please

@nephio-prow nephio-prow bot added the approved label Nov 2, 2023
@liamfallon
Copy link
Member

/approve

Copy link
Contributor

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

nephio-prow bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, liamfallon, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 048d979 into nephio-project:main Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants