-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added parser interface #84
Conversation
/verify-owners |
I was thinking something like this would be in the nephio/api repo |
this is part of the library and we created a lib under krm-functions as the code is more close to the functions versus the api. So we beleive something like this make sense: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. /lgtm
/assign @johnbelamaric |
Can you rebase? |
krm-functions/lib/parser/parser.go
Outdated
@@ -0,0 +1,24 @@ | |||
/* | |||
Copyright 2023 Nephio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's standardize on "The Nephio Authors"
Then I can merge this
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gvbalaji, henderiw, johnbelamaric The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a generic parser interface that would be used by all libraries that operation as krm functions