Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parser interface #84

Merged
merged 4 commits into from
Apr 10, 2023
Merged

added parser interface #84

merged 4 commits into from
Apr 10, 2023

Conversation

henderiw
Copy link
Contributor

@henderiw henderiw commented Apr 1, 2023

This is a generic parser interface that would be used by all libraries that operation as krm functions

@johnbelamaric
Copy link
Member

/verify-owners

@johnbelamaric
Copy link
Member

I was thinking something like this would be in the nephio/api repo

@henderiw
Copy link
Contributor Author

henderiw commented Apr 4, 2023

this is part of the library and we created a lib under krm-functions as the code is more close to the functions versus the api.
In the api repo we have added the getters, but the this is something to consume a library in a fn. So we believe this is a better fit in the function library.

So we beleive something like this make sense:
nephio/krm-functions/lib where a set of helpers libraries reside.

Copy link

@gvbalaji gvbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. /lgtm

@henderiw
Copy link
Contributor Author

henderiw commented Apr 7, 2023

/assign @johnbelamaric

@johnbelamaric
Copy link
Member

Can you rebase?

@@ -0,0 +1,24 @@
/*
Copyright 2023 Nephio.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's standardize on "The Nephio Authors"

Then I can merge this

@nephio-prow nephio-prow bot added the approved label Apr 10, 2023
@johnbelamaric
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Apr 10, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gvbalaji, henderiw, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [henderiw,johnbelamaric]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 2e727ac into nephio-project:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants