Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes to v1.27.1 in management cluster #152

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

electrocucaracha
Copy link
Member

It seems like Porch has some race conditions in older Kubernetes versions, this is an attempt to mitigate them.

@johnbelamaric
Copy link
Member

The race is in k8s API server CRD handling when two CRDs are registered with the same resource name (I think).

This may or may not fix it. A more assured fix would be to use the "cl" name for CAPI clusters rather than the full "clusters" name which seems to be shared with clusterregistry.

Either that, or see if maybe clusterregistry API resource doesn't exist in the older (or this newer) kind version. I don't know if that's used by CAPI or what.

@johnbelamaric
Copy link
Member

#153

Should fix the issue I am seeing for the tests failing due to timeouts waiting for clusters to be ready.

To fix the fragment issue - which is a known flake, not something that always happens - we need kptdev/kpt#3993. I do not think we need to wait for that for tagging our release.

@johnbelamaric
Copy link
Member

Flake: Error: the server is currently unable to handle the request (get packagerevisions.porch.kpt.dev)

This is a different issue than the fragment issue, but also a flake.

/retest

@radoslawc
Copy link
Collaborator

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 3, 2023
@electrocucaracha
Copy link
Member Author

/retest

@nephio-prow nephio-prow bot merged commit 4cb6be5 into nephio-project:main Jul 3, 2023
3 checks passed
@electrocucaracha electrocucaracha deleted the upgrade_k8s_mgmt branch July 3, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants