Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init.sh to work with a tag #160

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

johnbelamaric
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it
init.sh currently only works if the value passed into nephio-test-infra-branch is a branch, not if it is a tag. This is a problem for creating instructions that enable building a sandbox from a single command, based on a tag (e.g., v1.0.0).

Which issue(s) this PR fixes:
Partially fixes nephio-project/nephio#328

This will fix it for v1.0.1 and later. For v1.0.0, we need to create a branch to use, and tweak the instructions to use that branch name. Either that, or we need to move the v1.0.0 tag to a commit after this PR merges.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 7, 2023

@johnbelamaric: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it
init.sh currently only works if the value passed into nephio-test-infra-branch is a branch, not if it is a tag. This is a problem for creating instructions that enable building a sandbox from a single command, based on a tag (e.g., v1.0.0).

Which issue(s) this PR fixes:
Partially fixes nephio-project/nephio#328

This will fix it for v1.0.1 and later. For v1.0.0, we need to create a branch to use, and tweak the instructions to use that branch name. Either that, or we need to move the v1.0.0 tag to a commit after this PR merges.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric
Copy link
Member Author

/hold

Let me try this first. I have tested the individual bits but not the final result yet.

@johnbelamaric
Copy link
Member Author

/hold cancel

OK, it's working now.

Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed, but not tested.
/lgtm

Copy link
Member

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, johnbelamaric, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 49042bf into nephio-project:main Jul 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants