Externalize ansible variables

[electrocucaracha]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This change refactors some Ansible Roles to expose some variables and allow users to adjust them to their needs. It fixes some linting issues, removes some leftovers, and breaks down some playbooks to make them easier to understand. It also adds the documentation for the kpt role.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Expose `bootstrap` and `install` Ansible Roles variables

[nephio-prow]

@electrocucaracha: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This change refactors some Ansible Roles to expose some variables and allow users to adjust them to their needs. It fixes some linting issues, removes some leftovers, and breaks down some playbooks to make them easier to understand. It also adds the documentation for the kpt role.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Expose `bootstrap` and `install` Ansible Roles variables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[radoslawc]

/retest

[electrocucaracha]

/retest

[radoslawc]

/retest

[johnbelamaric]

The failure is in the last e2e test, the SMF scaling:

�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0m++ kubectl --kubeconfig /home/ubuntu/.kube/config get packagevariant regional-free5gc-smf-regional-free5gc-smf -o 'jsonpath={.status.downstreamTargets[0].name}'
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0m+ smf_deployment_pkg=regional-42cae84940985bdf2ecbbf93ac47f1f31fa7baa7
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0m+ echo 'Copying regional-42cae84940985bdf2ecbbf93ac47f1f31fa7baa7'
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0mCopying regional-42cae84940985bdf2ecbbf93ac47f1f31fa7baa7
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0m+ ws=regional-smf-scaling
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0m++ kpt alpha rpkg copy -n default regional-42cae84940985bdf2ecbbf93ac47f1f31fa7baa7 --workspace regional-smf-scaling
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0m++ cut -d ' ' -f 1
�[0m�[1mgoogle_compute_instance.e2e_instances[0] (remote-exec):�[0m �[0mError: Internal error occurred: source revision must be published

This is a flake, it's not related to the PR. The issue is that a new package revision is getting created by some controller, and this e2e test doesn't expect that. It's some timing issue with a controller, I saw a similar thing once in my testing too. It can be fixed with a more robust implementation of the e2e test that takes into account that another actor could be changing the package. I will raise an issue to work on that.

/retest

[johnbelamaric]

nephio-project/nephio#331

[johnbelamaric]

Different flake :(

SMF never fully deployed for some reason.

/retest

[johnbelamaric]

/approve

[nephio-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnbelamaric]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[radoslawc]

/lgtm