Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use andrewrothstein.kind kernel configuration #166

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
The andrewrothstein.kind Ansible role exposes variables to set kernel parameters. This PR takes advantage of that variable as well as updates/removes the python and galaxy requirements. This last change allows keeping dependencies updated. As additional improvement, it shows the network stats for every test.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
NA

Does this PR introduce a user-facing change?:


Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Aug 1, 2023

@electrocucaracha: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
The andrewrothstein.kind Ansible role exposes variables to set kernel parameters. This PR takes advantage of that variable as well as updates/removes the python and galaxy requirements. This last change allows keeping dependencies updated. As additional improvement, it shows the network stats for every test.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
NA

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@radoslawc
Copy link
Collaborator

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Aug 2, 2023
@nephio-prow nephio-prow bot merged commit 80843f5 into nephio-project:main Aug 2, 2023
3 checks passed
@electrocucaracha electrocucaracha deleted the upgrade_deps branch August 2, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants