Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding path alias in extra_refs and changing execution path #208

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

radoslawc
Copy link
Collaborator

Adding path alias in extra_refs and changing execution path in e2e periodics

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Periodic jobs doesn't checkout anything by default, extra_refs will do that so the execution path should be different
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@radoslawc
Copy link
Collaborator Author

/approve

@nephio-prow nephio-prow bot added the approved label Oct 27, 2023
Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [radoslawc,vjayaramrh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 10c1850 into nephio-project:main Oct 27, 2023
3 checks passed
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Oct 27, 2023

@radoslawc: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

Adding path alias in extra_refs and changing execution path in e2e periodics

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Periodic jobs doesn't checkout anything by default, extra_refs will do that so the execution path should be different
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants