Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assertions to 002.sh and 003.sh #216

Merged

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This change utilizes some assertion functions to validate the test resources, helping to minimize the errors caused by missing or invalid resources state. It also contains some refactoring and cleaning tasks.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Some instructions have been moved and requires updates on the documentation project.

Does this PR introduce a user-facing change?:


@electrocucaracha electrocucaracha changed the title Enable assertions to 002.sh Enable assertions to 002.sh and 003.sh Nov 14, 2023
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Copy link
Member Author

/retest

@electrocucaracha
Copy link
Member Author

/override e2e-fedora-34

Copy link
Contributor

nephio-prow bot commented Nov 15, 2023

@electrocucaracha: Overrode contexts on behalf of electrocucaracha: e2e-fedora-34

In response to this:

/override e2e-fedora-34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@radoslawc
Copy link
Collaborator

Looks good
/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 16, 2023
@nephio-prow nephio-prow bot merged commit 0dea816 into nephio-project:main Nov 16, 2023
5 checks passed
@electrocucaracha electrocucaracha deleted the add_assertions_002 branch November 16, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants