Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gce_run.sh to install needed Linux headers #53

Merged
merged 4 commits into from
May 26, 2023

Conversation

johnbelamaric
Copy link
Member

No description provided.

@johnbelamaric
Copy link
Member Author

@electrocucaracha PTAL

@johnbelamaric
Copy link
Member Author

So, in general this worked for me, but the repos that access gitea do not become ready, because gitea is not a valid host. We need to insert a service in the default namespace for that - or actually, maybe in the porch-server namespace.

But...I figure that's all going to change when we shift off the "one-summit" deployment, right? So, I didn't worry about it yet.

$ sed -e "s/vagrant/$USER/" < test-infra/e2e/provision/nephio.yaml > ~/nephio.yaml
$ cd test-infra/e2e/provision/
$ ./gce_run.sh
$ kubectl --kubeconfig ~/.kube/mgmt-config port-forward --namespace=nephio-webui svc/nephio-webui 7007
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this needs to be executed with sudo

Suggested change
$ kubectl --kubeconfig ~/.kube/mgmt-config port-forward --namespace=nephio-webui svc/nephio-webui 7007
$ sudo kubectl --kubeconfig ~/.kube/mgmt-config port-forward --namespace=nephio-webui svc/nephio-webui 7007

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this works fine without sudo since it's not a privileged port.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what happen, the one-summit repo is used by default. The CI has been changed to use the cluster-api with the DEPLOYMENT_TYPE env var.

@electrocucaracha
Copy link
Member

So, in general this worked for me, but the repos that access gitea do not become ready, because gitea is not a valid host. We need to insert a service in the default namespace for that - or actually, maybe in the porch-server namespace.

But...I figure that's all going to change when we shift off the "one-summit" deployment, right? So, I didn't worry about it yet.

Actually, the current version used to install gitea package is v1. I haven't had a chance to test v2 and use metal LB services.

/lgtm

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label May 26, 2023
@nephio-prow nephio-prow bot merged commit 0e8dc46 into nephio-project:main May 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants