Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nephio-operator image build #57

Merged
merged 1 commit into from
May 29, 2023
Merged

nephio-operator image build #57

merged 1 commit into from
May 29, 2023
+72 −0

Conversation

radoslawc
Copy link
Collaborator

@nephio-prow nephio-prow bot added the approved label May 29, 2023
vjayaramrh
vjayaramrh reviewed May 29, 2023
View reviewed changes
prow/config/config.yaml
branches:
- "main"
annotations:
description: Build and Push Image to DockerHub every commit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it more like after every PR that gets merged?

vjayaramrh
vjayaramrh approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, reviewed code to understand.

@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vjayaramrh
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label May 29, 2023
@nephio-prow nephio-prow bot merged commit 332caa2 into main May 29, 2023
3 checks passed
@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 29, 2023

@radoslawc: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

Fixes nephio-project/sig-release#34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@radoslawc radoslawc deleted the radoslawc-patch-10 branch May 31, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjayaramrh vjayaramrh vjayaramrh approved these changes

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees

@vjayaramrh vjayaramrh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
2 participants
@radoslawc @vjayaramrh