Update to latest nephio-controllers, nephio-workload-cluster packages #78
Conversation
johnbelamaric
changed the title
|
Also adds some little conveniences for the e2e VM user. |
johnbelamaric
force-pushed
the
conveniences
branch
from
5a36ad2
to
a05bebb
Compare
| @@ -13,7 +13,7 @@ | |||
| name: kpt | |||
| loop: | |||
| - {pkg: porch-dev, version: porch-dev/v2, namespaces: [porch-fn-system, porch-system]} | |||
| - {pkg: nephio-controllers, version: nephio-controllers/v4, namespaces: [nephio-system]} | |||
| - {pkg: nephio-controllers, version: nephio-controllers/v5, namespaces: [nephio-system]} | |||
There was a problem hiding this comment.
Is there a way to pull this version info instead of hardcoding it here? It can be done in a later PR hopefully
There was a problem hiding this comment.
Well, if we do that then we don't have a repeatable deployment. But agreed, this needs rework in R2 or R1++ to be simpler.
What I can do for now is force-push tags to move v5 to a new commit if I need another change. That doesn't go through our review process...
| @@ -26,7 +26,7 @@ source "${LIBDIR}/k8s.sh" | |||
|
|
|||
| kubeconfig="$HOME/.kube/config" | |||
|
|
|||
| workload_cluster_pkg_rev=$(kpt alpha rpkg get --name nephio-workload-cluster --revision v7 -o jsonpath='{.metadata.name}') | |||
| workload_cluster_pkg_rev=$(kpt alpha rpkg get --name nephio-workload-cluster --revision v8 -o jsonpath='{.metadata.name}') | |||
There was a problem hiding this comment.
You may already be thinking about pulling this value for version automatically instead of this being hard coded, right?
Maybe a good idea for others to look into this who are wanting to contribute?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, vjayaramrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.