Skip to content

Commit

Permalink
Rectify comment WRT wording and content
Browse files Browse the repository at this point in the history
Even though this is outdated, something similar needs to be implemented to address [issue \sailfishos-patches#332](sailfishos-patches#322).
  • Loading branch information
Olf0 authored and nephros committed Jul 25, 2023
1 parent d1341cc commit 94d0905
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/qml/WebPatchPage.qml
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ Page {
//property bool isCompatible: modelData.compatible.indexOf(PatchManager.osVersion) >= 0
property bool isCompatible: {
const osv = PatchManager.osVersion;
const checkVersion = osv.substr(osv.length - 3, osv.length ) // allow any patch compatible with minor-minor, assumes X.Y.Z.mm
const checkVersion = osv.substr(osv.length - 3, osv.length ) // allow any patch with compatible major.minor.micro release, but regardless of the pint release version. Assumes vX.Y.Z.P, with P comprising two diguts, which IS PLAINLY WRONG (see 3.0.0.9)! The dots are intended as separators, hence shall be used as such.
const compatVersions = modelData.compatible.map(function(v) { return v.substr(v.length -3, v.length) }) // reduce list of versions to X.Y.Z "compatible"
return compatVersions.indexOf(checkVersion) >= 0
}
Expand Down

0 comments on commit 94d0905

Please sign in to comment.