Support environment variables for enabled #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the example, config file contains enabled setting given with an environmental variable. It is very useful to control neptune with an env variable yet currently it is not possible. neptune: #GLOBAL CONFIG project: $NEPTUNE_PROJECT base_namespace: kedro enabled: $NEPTUNE_ENABLED
|
Hi @guemues Prince Canuma here, a Data Scientist at Neptune.ai, Thank you very much for submitting this PR! I have notified the team and they will be in touch with you soon. |
|
I'll really appreciate leaving a simple note in https://github.com/guemues/kedro-neptune/blob/6a560ec79f40cd0a178233bc213ed5f915c06824/CHANGELOG.md with a reference to this Pull Request. |
Raalsky
reviewed
May 4, 2022
enabled is an optional config so it needs to have a default value
Bump 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example, config file contains enabled setting given with an environmental variable. It is very useful to control neptune with an env variable yet currently it is not possible.
neptune:
#GLOBAL CONFIG
project: $NEPTUNE_PROJECT
base_namespace: kedro
enabled: $NEPTUNE_ENABLED