Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ss/add_omegaconfig_support #73

Merged
merged 14 commits into from
Nov 10, 2023
Merged

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Nov 9, 2023

  • Replaced AbstractDataSet, TextDataSet and CSVDataSet with AbstractDataset, TextDataset and CSVDataSet respectively
  • Replaced kedro.extras.datasets with kedro_datasets
  • Added kedro_datasets to requirements, and bumped kedro to >=0.18.5
  • Added OmegaConfig support
  • Updated e2e tests

@SiddhantSadangi SiddhantSadangi marked this pull request as ready for review November 9, 2023 16:47
@MarkusSagen
Copy link
Contributor

Nice! Looks good

@@ -7,7 +7,7 @@ jobs:
max-parallel: 4
matrix:
os: [ubuntu-latest, macos-latest]
python-version: [3.7, 3.8, 3.9, "3.10"]
python-version: [3.8, 3.9, "3.10", "3.11"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neptune-client still supports python 3.7. Could we leave it for the time being just to be on the safe side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kedro is dropping Python 3.7 support by the end of the year with 0.19.0 (#3090)

CHANGELOG.md Outdated Show resolved Hide resolved
@SiddhantSadangi SiddhantSadangi merged commit 978564b into main Nov 10, 2023
10 checks passed
@SiddhantSadangi SiddhantSadangi deleted the ss/add_omegaconfig_support branch November 10, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Integration not working with OmegaConfigLoader BUG: depretated package: neptune and kedro-datasets
3 participants