Skip to content

Commit

Permalink
Dataclasses removed from dependencies, bumped upload-artifact version…
Browse files Browse the repository at this point in the history
… to v3, and parallel unittests (#1267)
  • Loading branch information
Raalsky authored and shnela committed Feb 28, 2023
1 parent b97687b commit 157db21
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/actions/test-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ runs:
shell: bash

- name: Upload test coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: e2e-coverage
Expand All @@ -53,7 +53,7 @@ runs:
annotate_notice: true
job_name: ${{ inputs.report_job }}

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
if: always()
with:
name: test-artifacts
Expand Down
6 changes: 3 additions & 3 deletions .github/actions/test-unit/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,20 @@ runs:

- name: Test
run: |
coverage run -p -m pytest -v ./tests/unit/ \
coverage run -p -m pytest -v -n 2 ./tests/unit/ \
--timeout=120 --timeout_method=thread \
--junitxml="./test-results/test-unit-new-${{ inputs.os }}-${{ inputs.python-version }}.xml"
shell: bash

- name: Upload test coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: ${{ inputs.coverage-artifacts-name }}
path: ./.coverage*

- name: Upload test reports
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: test-artifacts
Expand Down
1 change: 0 additions & 1 deletion .github/neptune_client_pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ python = "^3.7"

# Python lack of functionalities from future versions
importlib-metadata = { version = "*", python = "<3.8" }
dataclasses = { version = ">=0.6", python = "<3.7" }

# Missing compatibility layer between Python 2 and Python 3
six = ">=1.12.0"
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ python = "^3.7"

# Python lack of functionalities from future versions
importlib-metadata = { version = "*", python = "<3.8" }
dataclasses = { version = ">=0.6", python = "<3.7" }

# Missing compatibility layer between Python 2 and Python 3
six = ">=1.12.0"
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/neptune/new/client/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,8 @@ def test_name_parameter(self):
with init_model(key="TRY", name="some_name") as exp:
exp.wait()
self.assertEqual(exp["sys/name"].fetch(), "some_name")

@unittest.skip("NPT-12753 Flaky test")
def test_async_mode_stop_on_dead(self):
# Check abstract mixin class for details
pass

0 comments on commit 157db21

Please sign in to comment.